[all] add support for Windows nodes #3222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
reviewed
Aug 18, 2024
There was a problem hiding this comment.
Just building the images doesn't resolve #642. The main blocker for that issue is testing, as we're not comfortable releasing or supporting untested images. As per Jacob's comment here, for us to accept this you either need to find a way to run tests in a cluster with Windows nodes in our CI, or commit to maintaining such tests externally, similar to what Red Hat does for OpenShift.
We're open to implementing this, but it's unfortunately not that simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support to build Windows images of the Docker images used by the operator and add them as an additional manifest platform on pushed images.
Link to tracking Issue(s):
Fixes #642
Testing:
Not much. I however have a k8s environment with Windows nodes to try things in.