Allow disabling the creation of the SM for operator metrics #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iblancasa
commented
Dec 3, 2024
iblancasa
commented
- Resolves: operator doesn't respect manager.serviceMonitor.enabled helm value #3474
swiatekm
approved these changes
Dec 3, 2024
jaronoff97
approved these changes
Dec 3, 2024
Contributor
jaronoff97
left a comment
jaronoff97
left a comment
There was a problem hiding this comment.
Do we need to worry about people who are already using this feature? Wouldn't starting it as disabled break people who had this from the previous version?
Contributor
|
We should label this as a breaking change, but imo disabled is the better default. Most of the time, packaging (usually Helm or kustomize) is going to take care of this. The intended use case here is primarily OpenShift in my view. |
Contributor
Author
|
Done @swiatekm |
swiatekm
approved these changes
Dec 4, 2024
frzifus
reviewed
Dec 5, 2024
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
frzifus
approved these changes
Feb 18, 2025
jaronoff97
approved these changes
Feb 18, 2025
Starefossen
pushed a commit
to Starefossen/opentelemetry-operator
that referenced
this pull request
Apr 10, 2025
…emetry#3509) Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.