[chore] move all target-allocator code to internal#3632
Merged
swiatekm merged 1 commit intoopen-telemetry:mainfrom Feb 24, 2025
Merged
[chore] move all target-allocator code to internal#3632swiatekm merged 1 commit intoopen-telemetry:mainfrom
swiatekm merged 1 commit intoopen-telemetry:mainfrom
Conversation
atoulme
force-pushed
the
move_to_internal
branch
from
3033807 to
3f2944a
Compare
Contributor
|
Looks good to me, broadly speaking. I would even consider moving all of it out of |
atoulme
force-pushed
the
move_to_internal
branch
from
3f2944a to
8aa8e00
Compare
jaronoff97
approved these changes
Feb 19, 2025
atoulme
force-pushed
the
move_to_internal
branch
from
8aa8e00 to
870d499
Compare
iblancasa
approved these changes
Feb 20, 2025
swiatekm
approved these changes
Feb 20, 2025
frzifus
approved these changes
Feb 21, 2025
Starefossen
pushed a commit
to Starefossen/opentelemetry-operator
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This is a proposed change and a test to see if we can move all the code under target allocator to internal, meaning its API is no longer public and exported.