Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding make target for python code generation #152

Merged
merged 2 commits into from
May 29, 2020

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented May 21, 2020

Left the generated code out as it will live in the opentelemetry-python repository as a separate installable package.

Partially fixes #91

@tigrannajaryan
Copy link
Member

Left the generated code out as it will live in the opentelemetry-python repository as a separate installable package.

@codeboten It is not clear what is the purpose of the change if the generate code does not live in this repo. Are the files going to be generated in some other repository? If so why is the makefile here and not in that other repo?

Or is this purely for convenience as a development tool for people who actively work on protos and want to see what it looks like in Python?

I may be missing some context, please clarify.

@codeboten
Copy link
Contributor Author

@tigrannajaryan that's correct, this was submitted here as a convenience for devs wanting to generate the protos.

Ultimately, I think it might make the most sense for the opentelemetry-proto package for python to be created from this repository since this is where the code lives, but that would require the process for packaging and publishing to be available here. Is the current plan that the SIG for each language maintain that process?

@tigrannajaryan
Copy link
Member

... Is the current plan that the SIG for each language maintain that process?

I am not sure what the ProtoBuf generation process looks like for Python an other languages so I don't have a good answer for this.

@bogdandrutu bogdandrutu merged commit 9fa4564 into open-telemetry:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish compiled files for Python
4 participants