Makefile: exclude Profiles protocol from breaking-changes #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Profiles protocol is still experimental. Exclude it from the breaking-changes check as such changes are expected at this stage. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This was referenced Aug 23, 2024
tigrannajaryan
approved these changes
Aug 23, 2024
|
With #577 a follow up to remove this special case handling for Profiling was added, to remove it once the Profiling signal becomes stable. |
|
@open-telemetry/spec-sponsors please review. |
|
@open-telemetry/profiling-maintainers please review/approve so that we can merge. |
christos68k
approved these changes
Aug 29, 2024
aalexand
approved these changes
Aug 29, 2024
felixge
approved these changes
Aug 29, 2024
tigrannajaryan
pushed a commit
that referenced
this pull request
Sep 12, 2024
#576 excluded the profiles definition from breaking changes. But the entire profiles protocol is in development and can have breaking changes, including the gRPC service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Profiles protocol is still experimental. Exclude it from the breaking-changes check as such changes are expected at this stage.