From 8322ee790e25b9103f4b527244959cad20d7817c Mon Sep 17 00:00:00 2001
From: John Bley <jbley@splunk.com>
Date: Tue, 16 Apr 2024 12:36:37 -0400
Subject: [PATCH] Fix all issues from shellcheck --severity=warning (#2354)

---
 .github/workflows/shellcheck.yml              | 19 +++++++++++++++++++
 .../proto/generate-proto-py.sh                |  1 -
 scripts/build.sh                              |  4 ++--
 scripts/build_a_package.sh                    |  8 ++++----
 scripts/coverage.sh                           |  3 ---
 5 files changed, 25 insertions(+), 10 deletions(-)
 create mode 100644 .github/workflows/shellcheck.yml

diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml
new file mode 100644
index 0000000000..68d12b805f
--- /dev/null
+++ b/.github/workflows/shellcheck.yml
@@ -0,0 +1,19 @@
+name: Shellcheck
+
+on:
+  push:
+    branches-ignore:
+    - 'release/*'
+  pull_request:
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install shellcheck
+        run: sudo apt update && sudo apt install --assume-yes shellcheck
+
+      - name: Run shellcheck
+        run: find . -name \*.sh | xargs shellcheck --severity=warning
diff --git a/exporter/opentelemetry-exporter-prometheus-remote-write/proto/generate-proto-py.sh b/exporter/opentelemetry-exporter-prometheus-remote-write/proto/generate-proto-py.sh
index 5f6129df55..a07181add3 100755
--- a/exporter/opentelemetry-exporter-prometheus-remote-write/proto/generate-proto-py.sh
+++ b/exporter/opentelemetry-exporter-prometheus-remote-write/proto/generate-proto-py.sh
@@ -6,7 +6,6 @@ PROTO_VERSION=v1.3.2
 
 # SRC_DIR is from protoc perspective. ie its the destination for our checkouts/clones
 SRC_DIR=opentelemetry/exporter/prometheus_remote_write/gen/
-DST_DIR=../src/opentelemetry/exporter/prometheus_remote_write/gen/
 
 #TODO:
 # Check that black & protoc are installed properly
diff --git a/scripts/build.sh b/scripts/build.sh
index fa490a6a35..247bb24b4e 100755
--- a/scripts/build.sh
+++ b/scripts/build.sh
@@ -8,13 +8,13 @@ set -ev
 # Get the latest versions of packaging tools
 python3 -m pip install --upgrade pip build setuptools wheel
 
-BASEDIR=$(dirname $(readlink -f $(dirname $0)))
+BASEDIR=$(dirname "$(readlink -f "$(dirname $0)")")
 DISTDIR=dist
 
 (
   cd $BASEDIR
   mkdir -p $DISTDIR
-  rm -rf $DISTDIR/*
+  rm -rf ${DISTDIR:?}/*
 
  for d in exporter/*/ opentelemetry-instrumentation/ opentelemetry-contrib-instrumentations/ opentelemetry-distro/ instrumentation/*/ propagator/*/ resource/*/ sdk-extension/*/ util/*/ ; do
    (
diff --git a/scripts/build_a_package.sh b/scripts/build_a_package.sh
index f3baa8a65a..333deccd80 100755
--- a/scripts/build_a_package.sh
+++ b/scripts/build_a_package.sh
@@ -22,7 +22,7 @@ set -ev
 
 if [ -z $GITHUB_REF ]; then
   echo 'Failed to run script, missing workflow env variable GITHUB_REF.'
-  exit -1
+  exit 1
 fi
 
 pkg_name_and_version=${GITHUB_REF#refs/tags/*}
@@ -40,13 +40,13 @@ cd $basedir
 
 distdir=${basedir}/dist
 mkdir -p $distdir
-rm -rf $distdir/*
+rm -rf ${distdir:?}/*
 
 pyproject_toml_file_path=$(ls **/$pkg_name/pyproject.toml)
 
 if [ -z $pyproject_toml_file_path ]; then
   echo "Error! pyproject.toml not found for $pkg_name, can't build."
-  exit -1
+  exit 1
 fi
 
 directory_with_package=$(dirname $pyproject_toml_file_path)
@@ -61,7 +61,7 @@ pkg_tar_gz_file=${pkg_name}-${pkg_version}.tar.gz
 
 if ! [ -f $pkg_tar_gz_file ]; then
   echo 'Error! Tag version does not match version built using latest package files.'
-  exit -1
+  exit 1
 fi
 
 # Build a wheel for the source distribution
diff --git a/scripts/coverage.sh b/scripts/coverage.sh
index 4015c6884a..02ce1eed55 100755
--- a/scripts/coverage.sh
+++ b/scripts/coverage.sh
@@ -11,9 +11,6 @@ function cov {
         ${1}
 }
 
-PYTHON_VERSION=$(python -c 'import sys; print(".".join(map(str, sys.version_info[:3])))')
-PYTHON_VERSION_INFO=(${PYTHON_VERSION//./ })
-
 coverage erase
 
 cov instrumentation/opentelemetry-instrumentation-flask