From 25688799678a6f7da8d805559dc99c078124e4de Mon Sep 17 00:00:00 2001 From: Johannes Liebermann Date: Wed, 23 Oct 2019 18:36:07 +0200 Subject: [PATCH] Add TODO --- .../src/opentelemetry/ext/opentracing_shim/__init__.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py b/ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py index fc97daf66c0..8cc28d2ed2d 100644 --- a/ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py +++ b/ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py @@ -164,6 +164,11 @@ def active(self): span_context = SpanContextShim(span.get_context()) wrapped_span = SpanShim(self._tracer, span_context, span) return ScopeShim(self, span=wrapped_span) + # TODO: The returned `ScopeShim` instance here always ends the + # corresponding span, regardless of the `finish_on_close` value used + # when activating the span. This is because here we return a *new* + # `ScopeShim` rather than returning a saved instance of `ScopeShim`. + # https://github.com/open-telemetry/opentelemetry-python/pull/211/files#r335398792 @property def tracer(self):