From 783d8b2c8fcf5d28f589e6806efef040321b1ce4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mauricio=20V=C3=A1squez?= Date: Fri, 1 Nov 2019 22:15:30 -0500 Subject: [PATCH] ext/jaeger: fix example The example of the jaeger exporter is failing because e4d89490e870 ("OpenTracing Bridge - Initial implementation (#211)") introduced a new timestamp parameter to add_event, the example was passing parameter by position so it was messed up. --- .../examples/jaeger_exporter_example.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/opentelemetry-ext-jaeger/examples/jaeger_exporter_example.py b/ext/opentelemetry-ext-jaeger/examples/jaeger_exporter_example.py index 5cf57bfccad..8f186e0b296 100644 --- a/ext/opentelemetry-ext-jaeger/examples/jaeger_exporter_example.py +++ b/ext/opentelemetry-ext-jaeger/examples/jaeger_exporter_example.py @@ -31,8 +31,8 @@ # create some spans for testing with tracer.start_as_current_span("foo") as foo: time.sleep(0.1) - foo.set_attribute("my_atribbute", True) - foo.add_event("event in foo", {"name": "foo1"}) + foo.set_attribute("my_attribute", True) + foo.add_event("event in foo", attributes={"name": "foo1"}) with tracer.start_as_current_span("bar") as bar: time.sleep(0.2) bar.set_attribute("speed", 100.0)