Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks workflow #3450

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Add benchmarks workflow #3450

merged 6 commits into from
Nov 3, 2023

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 28, 2023

Fixes #3449

Similar to:

open-telemetry/opentelemetry-js#4144
open-telemetry/opentelemetry-java#5842

For this to work, we also need a few changes:

  1. Create a benchmarks branch in this repo.
  2. Configure the URL path in Github pages (similar to this).

I tested this in a separate Github organization, here is the corresponding repo. The charts are published here.

open-telemetry/community#1700 tracks the changes needed to run these benchmarks on the open-telemetry Github organization runners.

@ocelotl ocelotl added the tests label Sep 28, 2023
@ocelotl ocelotl self-assigned this Sep 28, 2023
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 28, 2023
@ocelotl ocelotl marked this pull request as ready for review September 28, 2023 09:21
@ocelotl ocelotl requested a review from a team September 28, 2023 09:21
@ocelotl ocelotl requested a review from martinkuba October 1, 2023 09:51
@ocelotl
Copy link
Contributor Author

ocelotl commented Oct 4, 2023

Besides adding this workflow, part of the plan is to create a new orphan branch named benchmarks where there are 2 files. Rendering these files produces charts like these.

.github/workflows/benchmarks.yml Show resolved Hide resolved
.github/workflows/benchmarks.yml Show resolved Hide resolved
@ocelotl ocelotl enabled auto-merge (squash) November 3, 2023 21:01
@ocelotl ocelotl merged commit 952339c into open-telemetry:main Nov 3, 2023
111 checks passed
@ocelotl ocelotl deleted the issue_3449 branch November 3, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add benchmark tests
4 participants