From d74249417dd7b3eb7bfa9f2a6daf9e715068e36f Mon Sep 17 00:00:00 2001 From: Armin Ruech Date: Fri, 10 Jul 2020 11:27:10 +0200 Subject: [PATCH] Allow artificial destinations as span name if neither destination name nor conversation ID are suitable --- CHANGELOG.md | 2 +- specification/trace/semantic_conventions/messaging.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 62dde31ca19..37dd02edff2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ New: Updates: -- Adapt messaging semantic conventions to include the operation in the span name ([#690](https://github.com/open-telemetry/opentelemetry-specification/pull/690)) +- Adapt semantic conventions for the span name of messaging systems ([#690](https://github.com/open-telemetry/opentelemetry-specification/pull/690)) ## v0.6.0 (07-01-2020) diff --git a/specification/trace/semantic_conventions/messaging.md b/specification/trace/semantic_conventions/messaging.md index 8ceb6810a9c..038597afc80 100644 --- a/specification/trace/semantic_conventions/messaging.md +++ b/specification/trace/semantic_conventions/messaging.md @@ -77,6 +77,7 @@ The values allowed for `` are defined in the section [Operation The message destination name, i.e., the name of the topic or queue, is usually a low cardinality identifier suitable to be used as a span name. If the [conversation ID](#conversations) is expected to have lower cardinality than the message destination name, it SHOULD be used instead. In particular, the conversation ID SHOULD be used if the message destination is unnamed or [temporary](#temporary-destinations) unless multiple conversations can be combined to a logical destination of lower cardinality. +If the conversation ID on the other hand is expected to be of too high cardinality as well, introducing an artificial destination name instead is recommended. If the format above is used, the operation name MUST match the `messaging.operation` attribute defined for message consumer spans below. @@ -90,6 +91,7 @@ Examples: * `conversation-A1B2C3D4 send` * `conversation-A1B2C3D4 receive` * `AuthenticationRequest-Conversations process` +* `(temporary) send` (if neither the destination name nor the conversation ID have low cardinality) ### Span kind