Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the minimal implementation of a View's attribute_keys is an allow-list #3680

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 31, 2023

Additional filtering functionality is allowed for this parameter.

Fixes #3664
Resolves open-telemetry/opentelemetry-go#4156

Additional filtering functionality is allowed for this parameter.
@MrAlias MrAlias added the spec:metrics Related to the specification/metrics directory label Aug 31, 2023
@MrAlias MrAlias marked this pull request as ready for review August 31, 2023 15:32
@MrAlias MrAlias requested review from a team August 31, 2023 15:32
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 8, 2023

@carlosalberto can this be merged so it can be included in #3683? I think it is ready, right?

@reyang reyang merged commit 2bda856 into open-telemetry:main Sep 8, 2023
6 checks passed
@reyang
Copy link
Member

reyang commented Sep 8, 2023

@carlosalberto can this be merged so it can be included in #3683? I think it is ready, right?

+1

@MrAlias MrAlias deleted the attribute_keys branch September 8, 2023 20:43
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
No open projects
8 participants