Extend attribute naming rules to metric labels #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
added
the
area:semantic-conventions
tigrannajaryan
force-pushed
the
feature/tigran/metric-label-rules
branch
2 times, most recently
from
f4b7878
to
6c76204
Compare
bogdandrutu
reviewed
Aug 18, 2020
tigrannajaryan
force-pushed
the
feature/tigran/metric-label-rules
branch
2 times, most recently
from
7e59fe7
to
57ef431
Compare
bogdandrutu
approved these changes
Aug 18, 2020
arminru
approved these changes
Aug 19, 2020
added 2 commits
August 19, 2020 11:46
We earlier defined naming rules for attributes, however we do not have similar rules for metric labels. This commit extends the exact same set of rules to metric labels. This was brought up in this comment open-telemetry#807 (comment)
tigrannajaryan
force-pushed
the
feature/tigran/metric-label-rules
branch
from
57ef431
to
31693c0
Compare
|
No changes since 2 days ago, non controversial, merging |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Extend attribute naming rules to metric labels We earlier defined naming rules for attributes, however we do not have similar rules for metric labels. This commit extends the exact same set of rules to metric labels. This was brought up in this comment open-telemetry#807 (comment) * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We earlier defined naming rules for attributes, however we do not have
similar rules for metric labels. This commit extends the exact same
set of rules to metric labels.
This was brought up in this comment #807 (comment)