Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend attribute naming rules to metric labels #821

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Extend attribute naming rules to metric labels #821

merged 2 commits into from
Aug 19, 2020

Commits on Aug 19, 2020

  1. Extend attribute naming rules to metric labels 

    We earlier defined naming rules for attributes, however we do not have
similar rules for metric labels. This commit extends the exact same
set of rules to metric labels.

This was brought up in this comment open-telemetry#807 (comment)
    Tigran Najaryan committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    cf42129 View commit details
    Browse the repository at this point in the history

  2. Address PR comments

    Tigran Najaryan committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    31693c0 View commit details
    Browse the repository at this point in the history