From b556c5d1730688b91cf1850829cc89707b879861 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Wed, 26 Aug 2020 10:29:48 +0200 Subject: [PATCH 1/2] Fix Sampler.ShouldSample paramter descriptions. --- specification/trace/sdk.md | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index b1afff388f0..63baab28807 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -60,14 +60,12 @@ Returns the sampling Decision for a `Span` to be created. **Required arguments:** -* `SpanContext` of a parent `Span`. Typically extracted from the wire. Can be - `null`. -* `TraceId` of the `Span` to be created. It can be different from the `TraceId` - in the `SpanContext`. Typically in situations when the `Span` to be created - starts a new Trace. +* Parent `SpanContext`. May be invalid to indicate a root span. +* `TraceId` of the `Span` to be created. + If the parent `SpanContext` contains a valid `TraceId`, they always match. * Name of the `Span` to be created. -* `SpanKind` -* Initial set of `Attributes` for the `Span` being constructed +* `SpanKind` of the `Span` to be created. +* Initial set of `Attributes` of the `Span` to be created. * Collection of links that will be associated with the `Span` to be created. Typically useful for batch operations, see [Links Between Spans](../overview.md#links-between-spans). From c3b7e2eef5ed66863dad32504d2b842bdfcc8840 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Wed, 26 Aug 2020 14:36:51 +0200 Subject: [PATCH 2/2] MUST match --- specification/trace/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 63baab28807..176c7ba8088 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -62,7 +62,7 @@ Returns the sampling Decision for a `Span` to be created. * Parent `SpanContext`. May be invalid to indicate a root span. * `TraceId` of the `Span` to be created. - If the parent `SpanContext` contains a valid `TraceId`, they always match. + If the parent `SpanContext` contains a valid `TraceId`, they MUST always match. * Name of the `Span` to be created. * `SpanKind` of the `Span` to be created. * Initial set of `Attributes` of the `Span` to be created.