-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collector quick start #3787
Collector quick start #3787
Conversation
fb0722f
to
64ce48b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the changes. Sent some suggestions to reword things in line with our style recommendations.
works for me, if @theletterf is happy with the changes, I am happy to merge it |
Thanks all for the feedback, and for the careful review @theletterf. I've accepted all of your suggestions. Let me fix the formatting issues, etc. and then PTAL. |
9a3b6ad
to
24a566c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! Approved!
@open-telemetry/collector-approvers PTAL! |
c32b204
to
049dbdc
Compare
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
049dbdc
to
7b07d8b
Compare
@open-telemetry/collector-approvers PTAL! |
/fix:refcache |
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7696499988 |
This is a proposal to rename & slightly rework/refactor the Collector "getting started":
Thoughts @svrnm @theletterf et al.?
(For context, this is prep for #1635.)
Preview & redirect test: