Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector quick start #3787

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 16, 2024

This is a proposal to rename & slightly rework/refactor the Collector "getting started":

  • Renames the Collector Getting started to Quick start, since that is more what the page actually is.
  • Clarifies prerequisites
  • Slightly reorders commands
  • Offers some way to filter output, because otherwise it can be difficult to, e.g., find Span logs because the Collector output is very busy
  • Renames the page appropriately and adds an alias to handle redirects

Thoughts @svrnm @theletterf et al.?

(For context, this is prep for #1635.)


Preview & redirect test:

@chalin chalin requested review from a team and codeboten and removed request for a team January 16, 2024 14:48
@chalin chalin force-pushed the chalin-im-collector-quickstart-2024-01-16 branch from fb0722f to 64ce48b Compare January 16, 2024 14:57
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the changes. Sent some suggestions to reword things in line with our style recommendations.

content/en/docs/collector/quick-start.md Outdated Show resolved Hide resolved
content/en/docs/collector/quick-start.md Outdated Show resolved Hide resolved
content/en/docs/collector/quick-start.md Outdated Show resolved Hide resolved
content/en/docs/collector/quick-start.md Outdated Show resolved Hide resolved
content/en/docs/collector/quick-start.md Outdated Show resolved Hide resolved
content/en/docs/collector/quick-start.md Outdated Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented Jan 16, 2024

works for me, if @theletterf is happy with the changes, I am happy to merge it

@chalin
Copy link
Contributor Author

chalin commented Jan 16, 2024

Thanks all for the feedback, and for the careful review @theletterf. I've accepted all of your suggestions. Let me fix the formatting issues, etc. and then PTAL.

@chalin chalin force-pushed the chalin-im-collector-quickstart-2024-01-16 branch from 9a3b6ad to 24a566c Compare January 16, 2024 19:19
@chalin chalin requested review from a team and theletterf January 16, 2024 19:19
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Approved!

@svrnm
Copy link
Member

svrnm commented Jan 17, 2024

@open-telemetry/collector-approvers PTAL!

@chalin chalin force-pushed the chalin-im-collector-quickstart-2024-01-16 branch from c32b204 to 049dbdc Compare January 17, 2024 12:24
@svrnm svrnm added the sig-approval-missing Co-owning SIG didn't provide an approval label Jan 18, 2024
@chalin chalin force-pushed the chalin-im-collector-quickstart-2024-01-16 branch from 049dbdc to 7b07d8b Compare January 18, 2024 09:50
@svrnm
Copy link
Member

svrnm commented Jan 29, 2024

@open-telemetry/collector-approvers PTAL!

@svrnm
Copy link
Member

svrnm commented Jan 29, 2024

/fix:refcache

Copy link
Contributor

@svrnm svrnm merged commit 08a05ca into open-telemetry:main Jan 29, 2024
5 checks passed
@chalin chalin deleted the chalin-im-collector-quickstart-2024-01-16 branch January 29, 2024 15:12
jaydeluca pushed a commit to jaydeluca/opentelemetry.io that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants