-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a "HOW-TO: Building your own collector" tutorial to the collector #1277
Adding a "HOW-TO: Building your own collector" tutorial to the collector #1277
Conversation
…tor docs to support the development of a How-to doc series for component development
Similar to the other PR, just wanted to mention that you might want to compare this with the blog post I published some time ago, and which is certainly outdated by now: https://medium.com/opentelemetry/building-your-own-opentelemetry-collector-distribution-42337e994b63 |
Absolutely! Your blog is a more complete walkthrough, this one is using the builder tool so people can quickly bootstrap for component development. I would say they are actually complimentary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammar nits
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
thank you @austinlparker ! I merged all your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few recommendations
….com/rquedas/opentelemetry.io into doc-collector-howto-custom-collector
@austinlparker and @svrnm, can you take a look at the latest update and tell me if there is anything else we need to address? |
@svrnm lmk if this is g2g |
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
@austinlparker , all my issues have been addressed, leaving it to the expert @jpkrohling with the remaining open issues :-) |
@jpkrohling is this good to go? |
I'm still not 100% happy with this. @rquedas, is this OK if I send another commit to your PR? |
Absolutely! |
@jpkrohling, I will start refactoring the trace receiver tutorial to support 0.50.0 model changes, so when you are finished with this one we can have both available. Does that sound like a plan? |
@jpkrohling would you still prefer to commit against this branch and then merge, or merge now and contribute a change later? |
@austinlparker, @svrnm and @jpkrohling, just merged changes to reflect "v0.53.0". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added several suggestions, but otherwise lgtm. As a general tip, you don't need to add qualifiers to statements ('where you basically pass' vs. 'where you pass') in docs.
@austinlparker, thank you for taking the time in reviewing it and making the suggestions. I merged all of them. |
Docs automatically get added to the sidebar when they're added. @jpkrohling you have a requested change; Would you like to commit that directly or add a PR after the merge? |
….com/rquedas/opentelemetry.io into doc-collector-howto-custom-collector
….com/rquedas/opentelemetry.io into doc-collector-howto-custom-collector
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Austin Parker <austin@ap2.io>
951db35
to
d478359
Compare
Rebased since this PR has been open for a while and needed to catch up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
@rquedas - see my inline comments for possible final changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it! Woohoo! Thanks all!
Hoping to start a series of "HOW-TO" docs in the collector to help developers learning how to build components like the one I am proposing here Tutorial on how to build a trace receiver #1265
This would be the step one in the journey for component developers.
Preview: https://deploy-preview-1277--opentelemetry.netlify.app/docs/collector/howto-custom-collector/