Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'latest' url to download java agent. #1469

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Use 'latest' url to download java agent. #1469

merged 1 commit into from
Jun 21, 2022

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 21, 2022

Minor fix for Java - Getting Started, this makes use of Linking to releases to always have the latest version of opentelemetry-javaagent.jar downloaded

@svrnm svrnm requested review from a team June 21, 2022 15:39
trask
trask approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chalin
chalin reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the page contains occurrences of the version ID, we might want to consider another approach: use a (Hugo) variable to hold the "current" Java OTel version. This way, the page text and the downloaded version would stay in sync.

If y'all are satisfied with what is being proposed by this PR, that works for me too

@chalin
Copy link
Contributor

chalin commented Jun 21, 2022

This is the issue that's related to what I mentioned above:

@chalin chalin mentioned this pull request Jun 21, 2022
Open
1 task
chalin
chalin approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given all the approvals, I'm going to merge this. I've added a note to #1194 in case we'd like to revert this change.

@chalin chalin merged commit f9ba3bf into open-telemetry:main Jun 21, 2022
@chalin
Copy link
Contributor

chalin commented Jun 21, 2022

Thanks all!

@trask
Copy link
Member

trask commented Jun 21, 2022

use a (Hugo) variable to hold the "current" Java OTel version. This way, the page text and the downloaded version would stay in sync.

I'd be good with that also

@svrnm svrnm deleted the java-always-latest-agent branch May 11, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@cartermp cartermp cartermp approved these changes

@chalin chalin chalin approved these changes

@laurit laurit laurit approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@svrnm @chalin @trask @laurit @cartermp @mateuszrzeszutek