[chore] Accessible links 5 #6053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rogercoll
approved these changes
Jan 23, 2025
|
@jsoref Please fix the conflict and push to the branch, thanks! |
jsoref
force-pushed
the
accessible-links-5
branch
from
bb03c89 to
5c3bbbf
Compare
chalin
requested changes
May 22, 2025
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
functions 7 Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
chalin
force-pushed
the
accessible-links-5
branch
from
5c3bbbf to
a8ec035
Compare
chalin
reviewed
May 27, 2025
chalin
approved these changes
May 27, 2025
There was a problem hiding this comment.
Unblocking as @avillela is looking into making has made the video public again if she can. I'd like this PR merged since it influences the markdownlint update I'm working on. We'll track the video permissions issue separately.
|
@jsoref - thanks for your patience and for these updates 🙌🏻 Merging! |
EzzioMoreira
pushed a commit
to EzzioMoreira/opentelemetry.io
that referenced
this pull request
Jun 12, 2025
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
tiffany76
pushed a commit
to BeverlyJaneJ/opentelemetry.io
that referenced
this pull request
Jun 18, 2025
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web isn't limited to people who read content with their eyes. Some users use screen readers and other accessibility agents and some people have other reasons for appreciating descriptive links. To that end, check-spelling/spell-check-this includes a rule:
Do not use
(click) herelinksFor more information, see:
The changes included here are designed to help users who benefit from descriptive links