-
Notifications
You must be signed in to change notification settings - Fork 1.6k
refactor : Rename and split up Collector installation page #8370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: adity1raut <araut7798@gmail.com>
|
PTAL @tiffany76 |
tiffany76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good, @adity1raut! I've left some comments based on my first-pass review. Once we address those, I'll take a closer look. Thanks!
| @@ -0,0 +1,140 @@ | |||
| --- | |||
| title: Install the Collector on Linux | |||
| aliases: [../installation/#linux] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chalin I know this alias won't work because the source is a fragment. How do we keep the fragment's target and point it to an alert about refactoring?
Signed-off-by: adity1raut <araut7798@gmail.com>
Signed-off-by: adity1raut <araut7798@gmail.com>
|
@tiffany76 Can you please Give me review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiffany76 - is there a reason to prefer naming the section install vs the original installation? If we keep the original name then we won't need any aliases.
(And your right, there should be a single alias in this refactoring.)
|
@chalin All of the top level pages that instruct people how to do things will be verbs: Install, Configure, Deploy, Manage, Extend. I'd like the iA to be uniform. |
|
@tiffany76 - that works for me. Then this PR should have a single alias in the |
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @tiffany76 agrees with the linkTitles, add appropriate linkTitle entries to each page based on the examples I have given in the comments below.
|
/fix:refcache |
|
ℹ️ |
I think they're probably good, but I'd like to get the page weights sorted out so I can see how the nav looks in the preview before settling for sure on the linkTitles. |
tiffany76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adity1raut! I've made some suggested changes to address the outstanding issues. If you commit them, I'll do a final review and we can hopefully get this merged. Thanks!
|
The link checker also found that a 2024 blog post is referring to the old installation page. If you can update the reference in |
Signed-off-by: adity1raut <araut7798@gmail.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
|
@adity1raut I'm repasting my earlier comment. This PR is very close, but you'll need to fix the following issue before we can move forward. Thanks!
|
Signed-off-by: Tiffany Hrabusa <tiffany.hrabusa@grafana.com>
tiffany76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adity1raut - I updated the 2024 blog post on your branch because we need to get this merged.
Thanks for your contribution!
|
Thank you for your contribution @adity1raut! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
…metry#8370) Signed-off-by: adity1raut <araut7798@gmail.com> Signed-off-by: Tiffany Hrabusa <tiffany.hrabusa@grafana.com> Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Co-authored-by: Tiffany Hrabusa <tiffany.hrabusa@grafana.com>
Description
This PR Fixed #8353 refactors the Collector installation documentation by renaming, restructuring, and splitting the existing installation page into multiple focused sections. The goal is to improve clarity, organization, and navigation within the documentation.
Changes ...
Changes
Rename the page and update front matter:
Move and rename the file to
index.md.Add an alias in the front matter:
Create new child pages:
content/en/docs/collector/install/docker.md— Install the Collector with Dockercontent/en/docs/collector/install/kubernetes.md— Install the Collector with Kubernetesindex.md— Install from a Collector binarycontent/en/docs/collector/install/binary/linux.md— Install the Collector on Linuxcontent/en/docs/collector/install/binary/macos.md— Install the Collector on macOScontent/en/docs/collector/install/binary/windows.md— Install the Collector on WindowsEach new child page includes front matter with a redirect from the old location.
Content migration:
/install/./install/.Update cross-references:
/docs/collector/installation/inquick-start.md(line 131) and anywhere else within the English documentation.Related Issues / References
Additional Notes
This restructuring improves the logical flow and maintainability of Collector installation documentation.
Run
npm run fix:alllocally to ensure style and formatting compliance.Preview: https://deploy-preview-8370--opentelemetry.netlify.app/docs/collector/install/
Redirect test: https://deploy-preview-8370--opentelemetry.netlify.app/docs/collector/installation/