Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #31

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Update README.md #31

merged 5 commits into from
Sep 13, 2023

Conversation

anjan-keysight
Copy link
Collaborator

Data added for minimum resource requirements.

Data added for minimum resource requirements.
@anjan-keysight
Copy link
Collaborator Author

@bortok @apratimmukherjee I have updated README with minimum resource requirements, kindly review.

Copy link

@apratimmukherjee apratimmukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Few comments provided.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@bortok bortok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anjan,

I believe the min requirements values don't belong to the operator repository, and instead should be documented in Ixia-c repo, probably here https://github.com/open-traffic-generator/ixia-c/blob/mkdocs/docs/prerequisites.md. You could reference that documentation from this readme and explain the operator is honoring these numbers.

@anjan-keysight
Copy link
Collaborator Author

@bortok I have updated the ixia-c prerequisites directly, and added link from this README, as you suggested.

@bortok
Copy link

bortok commented Sep 8, 2023

@anjan-keysight high chance we will forget to update the link to point to main once mkdocs branch is merged. Could you please track it so that we don't? Otherwise, I'm good.

@anjan-keysight
Copy link
Collaborator Author

I will keep note and update again when mkdocs is merged.

@anjan-keysight anjan-keysight merged commit b99440e into main Sep 13, 2023
2 checks passed
@anjan-keysight anjan-keysight deleted the dev-resource-reqm branch September 13, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants