Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DS-1766] Adds '#states' functionality to the add Alert node form. #147

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[DS-1766] Adds '#states' functionality to the add Alert node form. #147

merged 1 commit into from
Dec 3, 2024

Conversation

aleevas
Copy link
Contributor

@aleevas aleevas commented Nov 28, 2024

Jira: DS-1766

Steps for review

  • log as admin
  • go to /admin/modules
  • enable the Small Y Alerts module
  • hover over content > add content >click on Alert
  • fill in required fields
  • verify that you can see new options in the Alert Style field
  • select Classic style
  • verify that Fields for classic styles are displayed
  • select other styles
  • check if the Fields for classic styles are hidden

rollki
rollki approved these changes Dec 2, 2024
View reviewed changes
Copy link

@rollki rollki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@aleevas aleevas marked this pull request as ready for review December 2, 2024 14:36
@podarok podarok merged commit 1c0e642 into open-y-subprojects:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rollki rollki rollki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleevas @rollki @podarok