Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on backend selection with load_collection property filtering #58

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

soxofaan
Copy link
Contributor

Covers documentation part of openEOPlatform/architecture-docs#268

@soxofaan soxofaan requested a review from m-mohr February 17, 2023 09:32
@m-mohr
Copy link
Collaborator

m-mohr commented Feb 17, 2023

This looks good, but while reading it my head thinks about whether it is really a good idea to encode this selection into the process graph? It has nothing to do with the actual workflow and as such, may it be better to add this to the "additional" properties for a data processing request (i.e. where VITO also now has the memory options etc.)?

@soxofaan
Copy link
Contributor Author

whether it is really a good idea to encode this selection into the process graph? It has nothing to do with the actual workflow and as such, may it be better to add this to the "additional" properties for a data processing request (i.e. where VITO also now has the memory options etc.)?

The original idea (bootstrapped at https://github.com/openEOPlatform/architecture-docs/issues/85 ) is to use existing APIs, and making sure it works both for sync and batch jobs.
What you propose requires defining something new (in federation extension), right? And it would not readily be supported in clients I think (at least for sync processing).

@m-mohr
Copy link
Collaborator

m-mohr commented Feb 17, 2023

Yeah, it's more a second thought. It sounds less appealing after a lot of discussions recently about load_collection, filtering and the additional job/sync/service options. Client support is likely limited although allowed by the API (also for synchronous). So it would not be a cheap solution, but is good for a cleaner implementation in the long-run. It's also something that would benefit hugely from Open-EO/openeo-api#471.

Anyway, to not overcomplicate things, let's go for the proposed solution in this PR for now.

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but rendering will likely be broken (see the other comment).

@soxofaan
Copy link
Contributor Author

done

@m-mohr m-mohr merged commit 9b9ff8f into main Feb 27, 2023
@m-mohr m-mohr deleted the federation-backends-property-filtering branch February 27, 2023 14:14
@m-mohr
Copy link
Collaborator

m-mohr commented Feb 27, 2023

Has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants