Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce debug memory monitoring #457

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Introduce debug memory monitoring #457

merged 1 commit into from
Sep 19, 2023

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Sep 19, 2023

that alerts and prints additional debug information in case Poseidon exceeds 1 GB of memory usage.

Related to #453

that alerts and prints additional debug information in case that Poseidon exceeds 1 GB of memory usage.
@mpass99 mpass99 self-assigned this Sep 19, 2023
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine to add such a debug statement and hope that the memory increase is "slow enough" to trigger it.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #457 (4ea328f) into main (c83bdbf) will increase coverage by 7.89%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   67.88%   75.78%   +7.89%     
==========================================
  Files          37       39       +2     
  Lines        3407     3642     +235     
==========================================
+ Hits         2313     2760     +447     
+ Misses        949      712     -237     
- Partials      145      170      +25     
Files Changed Coverage Δ
cmd/poseidon/main.go 61.22% <53.57%> (+30.27%) ⬆️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mpass99 mpass99 merged commit f670b07 into main Sep 19, 2023
11 of 12 checks passed
@mpass99 mpass99 deleted the fix/#453-oom branch September 19, 2023 20:31
@sentry-io
Copy link

sentry-io bot commented Sep 19, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants