From f1142c9fd299814a72a1a1e71a2bac6724e37aa4 Mon Sep 17 00:00:00 2001 From: Deepak Kumar Date: Tue, 5 Jan 2021 12:30:46 +0530 Subject: [PATCH 1/4] Remove All Hardcoded strings and other warnings --- build.gradle | 2 +- gradle/wrapper/gradle-wrapper.properties | 5 ++--- mifospay/src/main/res/layout/activity_login.xml | 3 ++- .../res/layout/activity_merchant_transaction.xml | 3 ++- mifospay/src/main/res/layout/activity_read_qr.xml | 6 ++++-- mifospay/src/main/res/layout/activity_receipt.xml | 3 ++- .../main/res/layout/activity_setup_upi_pin.xml | 3 ++- mifospay/src/main/res/layout/activity_show_qr.xml | 3 ++- mifospay/src/main/res/layout/activity_signup.xml | 3 ++- .../content_bottom_sheet_account_details.xml | 3 ++- .../main/res/layout/dialog_transaction_detail.xml | 15 ++++++++++----- mifospay/src/main/res/layout/faq_list_group.xml | 4 +++- mifospay/src/main/res/layout/fragment_cards.xml | 3 ++- .../src/main/res/layout/fragment_kyc_lvl2.xml | 3 ++- .../src/main/res/layout/fragment_merchants.xml | 3 ++- mifospay/src/main/res/layout/fragment_request.xml | 6 ++++-- mifospay/src/main/res/layout/invoice_item.xml | 2 +- mifospay/src/main/res/layout/item_casual_list.xml | 3 ++- mifospay/src/main/res/layout/item_si.xml | 4 ++-- .../main/res/layout/item_specific_transaction.xml | 15 ++++++++++----- .../src/main/res/layout/nav_drawer_header.xml | 13 +++++++++---- .../res/layout/profile_username_and_image.xml | 3 ++- mifospay/src/main/res/values/strings.xml | 1 + 23 files changed, 71 insertions(+), 38 deletions(-) diff --git a/build.gradle b/build.gradle index 1c12e2598..88cae66dc 100644 --- a/build.gradle +++ b/build.gradle @@ -8,7 +8,7 @@ buildscript { maven { url 'https://maven.google.com' } } dependencies { - classpath 'com.android.tools.build:gradle:3.6.3' + classpath 'com.android.tools.build:gradle:4.1.1' classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1' classpath 'com.google.gms:google-services:4.3.3' classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.72" diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index e39a858cd..a4cb02c15 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,7 +1,6 @@ -#Mon Jan 14 18:31:05 IST 2019 +#Tue Jan 05 11:16:33 IST 2021 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-all.zip - +distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-bin.zip diff --git a/mifospay/src/main/res/layout/activity_login.xml b/mifospay/src/main/res/layout/activity_login.xml index 6fc8f9169..a93358962 100644 --- a/mifospay/src/main/res/layout/activity_login.xml +++ b/mifospay/src/main/res/layout/activity_login.xml @@ -18,7 +18,8 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" app:layout_constraintVertical_bias="0.774" - app:srcCompat="@drawable/ic_logo_outline" /> + app:srcCompat="@drawable/ic_logo_outline" + android:contentDescription="@string/todo" /> + app:srcCompat="@drawable/shape_bottom_sheet_dialog_grip" + android:contentDescription="@string/todo" /> + app:srcCompat="@drawable/ic_flash_on" + android:contentDescription="@string/todo" /> + app:srcCompat="@drawable/ic_flash_off" + android:contentDescription="@string/todo" /> diff --git a/mifospay/src/main/res/layout/activity_receipt.xml b/mifospay/src/main/res/layout/activity_receipt.xml index 8b6323212..55ca38647 100644 --- a/mifospay/src/main/res/layout/activity_receipt.xml +++ b/mifospay/src/main/res/layout/activity_receipt.xml @@ -28,7 +28,8 @@ android:layout_width="@dimen/value_120dp" android:layout_height="@dimen/value_120dp" android:layout_gravity="center" - app:srcCompat="@drawable/mifospay_round_logo" /> + app:srcCompat="@drawable/mifospay_round_logo" + android:contentDescription="@string/todo" /> + android:visibility="gone" + android:layout_alignParentEnd="true" /> diff --git a/mifospay/src/main/res/layout/activity_show_qr.xml b/mifospay/src/main/res/layout/activity_show_qr.xml index 8805fb275..b65a59f07 100644 --- a/mifospay/src/main/res/layout/activity_show_qr.xml +++ b/mifospay/src/main/res/layout/activity_show_qr.xml @@ -14,7 +14,8 @@ + android:layout_height="match_parent" + android:contentDescription="@string/todo" />