Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependencies with multiple integrity values #35

Closed
wants to merge 3 commits into from

Conversation

marcosbc
Copy link
Contributor

@marcosbc marcosbc commented Sep 18, 2023

Fixes #34

This PR fixes the scenario where a package-lock.json file may include dependencies with multiple integrity values, as it would cause an error on the OBS side when building. The solution involves selecting the first defined integrity and checking against that, and ignoring any other one.

Copy link
Member

@AdamMajer AdamMajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to fix the problem but moving the README changes to different PR or at least different commit would be nice.

README.md Outdated Show resolved Hide resolved
node_modules.py Outdated Show resolved Hide resolved
@AdamMajer
Copy link
Member

I've squashed these commits and merged them now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when dependencies specify multiple integrity values
2 participants