Split github action workflows into two separate workflows #14159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krauselukas
force-pushed
the
fix/use_pull_request_target
branch
from
4c2cd0e to
eecca7c
Compare
hennevogel
approved these changes
Apr 13, 2023
In order to allow the creation of comments on PR's that are coming from forks, we would need to use the `:pull_request_target` event over the `:pull_request` event. Since the `:pull_request_target` event comes with more permissions on the target repo, its not recommended to checkout the code coming from an untrusted fork. Therefore the gh action workflow is now splited into two separate workflows. One workflow keeps working on the `:pull_request` event and checksout the code to perform the diff operation in order to receive gem name, version etc. Afterwards the informations are saved as artifacts. The second workflow listens for the `workflow_run` event and gets triggered after the first one finished successfully, then downloads the artifacts and finally creates the comment (the `:workflow_run` event has permission to comment on the PR).
krauselukas
force-pushed
the
fix/use_pull_request_target
branch
from
eecca7c to
359b519
Compare
|
Codecov hangs. Coverage is fine though. See the checks. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow the creation of comments on PR's that are
coming from forks, we would need to use the
:pull_request_targetevent over the
:pull_requestevent. Since the:pull_request_targetevent comes with more permissions on the target repo, its not recommended to
checkout the code coming from an untrusted fork.
Therefore the gh action workflow is now split into two separate
workflows.
One workflow keeps working on the
:pull_requestevent and checksoutthe code to perform the diff operation in order to receive gem
name, version etc. Afterwards the informations are saved as artifacts.
The second workflow listens for the
workflow_runevent and getstriggered after the first one finished successfully, then downloads
the artifacts and finally creates the comment (the
:workflow_runevent has permission to comment on the PR).
For reference https://securitylab.github.com/research/github-actions-preventing-pwn-requests/