-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hard-Coded Bugzilla Link ("Report Bug") #36
Comments
yes thanks I will run it by the team perhaps we can fix it quickly. |
@fsundermeyer Could you look into the JavaScript code and see if this is possible? Thanks! |
IdeaA tracker URL shouldn't be hard-coded into the JavaScript code. Maybe we should integrate the tracker URL into our XML sources as meta information. Or we pass it as a parameter to our XSLT stylesheets set by daps. Anyway, the variable var bugzillaURLprefix = 'https://bugzilla.suse.com/enter_bug.cgi?&product=' // ... we should better replace it with a function that returns the complete tracker URL: var bugzillaURLprefix = extractTrackerURL(encodeURIComponent(bugzillaProduct), encodeURIComponent(bugzillaComponent)); The idea is, to add information about the tracker URL to our XML sources and transform it into a <meta name="tracker-url" content="{$tracker.url}"/> The advantage is we don't have any hard-coded URLs anymore and we are more flexible. Don't know how to code this in JavaScript... |
GitHub also supports the Query syntax in the URL too. |
* Removed switch/case cascade -> this should go into the corresponding XML source * Removed hard-coded Bugzilla URL -> should go also in the XML source * URL componentss are retrieved by <meta> tags
Ok, here is the current state:
As Manuel already mentioned, the Bugzilla and GitHub URLs can contain "query strings". The following table lists the relevant field keywords for each tracker:
Footnotes:
The advantage of the above approch is:
|
* Introduced new parameter use.tracker.meta: used to control meta creation of bugtracker information * Removed obsolete tracker.url template * Created new tracker.meta.xsl file which handles all tracker related transformation * Include tracker.meta.xsl in docbook.xsl
In our HTML, each section (or title) contains a "Report Bug" link. At the moment, this points to Bugzilla. It would be nice, to make this customizable, for example, to link to GitHub.
At the moment, this file is responsible for that:
suse2013/static/js/script.js
@jcayouette Is that good enough?
The text was updated successfully, but these errors were encountered: