[codex] tell model that interactive mode is off when approval policy is equal never #5992
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| )); | ||
| match approval_policy { | ||
| AskForApproval::Never => { | ||
| lines.push(" <interactive_mode>false</interactive_mode>".to_string()); | ||
| } | ||
| _ => lines.push(" <interactive_mode>true</interactive_mode>".to_string()), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Never approval mode as non-interactive
Equating AskForApproval::Never with a non-interactive session isn’t correct. We still run fully interactive flows (e.g. the TUI/CLI with --dangerously-bypass-approvals-and-sandbox) where the user is present, but we set approval_policy to Never just to skip command prompts (codex-rs/tui/src/lib.rs). With the new branch we would emit <interactive_mode>false</interactive_mode> for those sessions, telling the model it cannot ask the user for anything even though the UI is interactive. That regresses the interactive experience. Please derive interactive_mode from the actual session source/flag rather than the approval policy, or omit the field until we can do so.
Useful? React with 👍 / 👎.
No description provided.