Skip to content

Chore: read mcp servers config via app server #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Chore: read mcp servers config via app server #7258

wants to merge 2 commits into from

Conversation

@shijie-oai
Copy link
Collaborator

@shijie-oai shijie-oai commented Nov 24, 2025

Summary

  • Added GetMcpServersConfig which reads the MCP servers defined in config.toml.

Write function will come as a separate PR.

@shijie-oai shijie-oai requested review from gpeal and owenlin0 November 24, 2025 22:19
owenlin0
owenlin0 reviewed Nov 24, 2025
View reviewed changes
Copy link
Contributor

@owenlin0 owenlin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jif-oai has a PR to read (and write) config values generally, could we use that instead? #7241

@shijie-oai
Copy link
Collaborator Author

shijie-oai commented Nov 24, 2025

@jif-oai has a PR to read (and write) config values generally, could we use that instead? #7241

Ya we should be able to - bumping this back to draft and will update when that PR is merged.

@shijie-oai
Copy link
Collaborator Author

shijie-oai commented Nov 25, 2025

@owenlin0 Can we actually get this PR in and I will swap it out to use the API from the PR above? My work in VSCE depends on this and I don't want it to be a blocker.

@shijie-oai shijie-oai marked this pull request as ready for review November 25, 2025 06:20
@shijie-oai
Copy link
Collaborator Author

shijie-oai commented Nov 25, 2025

@owenlin0 nvm saw that it is merged this morning - I will convert now.

@shijie-oai shijie-oai marked this pull request as draft November 25, 2025 17:14
@shijie-oai shijie-oai closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owenlin0 owenlin0 owenlin0 left review comments

@gpeal gpeal Awaiting requested review from gpeal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shijie-oai @owenlin0