From 36797528ddaf753bf42dd718d73ce68c74d8d434 Mon Sep 17 00:00:00 2001 From: Josemi Date: Mon, 23 Sep 2024 15:53:08 +0200 Subject: [PATCH 1/2] wc: Fix validation in variant interpreter grid config #TASK-5589 --- .../interpretation/variant-interpreter-grid-config.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js b/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js index c2c280931..7c21606e4 100644 --- a/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js +++ b/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js @@ -207,8 +207,12 @@ export default class VariantInterpreterGridConfig extends LitElement { type: "pills", validation: { validate: data => { - return data.geneSet?.ensembl || data.geneSet?.refseq; - } + // make sure that geneSet is present in the data object + if (typeof data.geneSet !== "undefined") { + return data.geneSet?.ensembl || data.geneSet?.refseq; + } + return true; + }, }, display: { width: 12, From 4bd0018d63fa21428621bdc53e1f2e410274bf56 Mon Sep 17 00:00:00 2001 From: Josemi Date: Mon, 23 Sep 2024 15:53:32 +0200 Subject: [PATCH 2/2] wc: Fix validation message in variant interpreter grid config #TASK-5589 --- .../variant/interpretation/variant-interpreter-grid-config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js b/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js index 7c21606e4..560bd6485 100644 --- a/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js +++ b/src/webcomponents/variant/interpretation/variant-interpreter-grid-config.js @@ -213,6 +213,7 @@ export default class VariantInterpreterGridConfig extends LitElement { } return true; }, + message: "You must select at least one Gene Set (Ensembl or RefSeq) in Transcript Filter.", }, display: { width: 12,