Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dummy model use when testing forecasting with PV sites #105

Open
Sukh-P opened this issue Sep 30, 2024 · 0 comments
Open

Remove dummy model use when testing forecasting with PV sites #105

Sukh-P opened this issue Sep 30, 2024 · 0 comments

Comments

@Sukh-P
Copy link
Member

Sukh-P commented Sep 30, 2024

For pv sites we currently aren't testing against our actual models and instead are using the dummy model https://github.com/openclimatefix/india-forecast-app/blob/main/tests/test_app.py#L81 which generates fake predictions, I imagine this was done previously when pv models weren't quite ready but perhaps now it feels like the right time to remove this to improve our model test coverage.

A wider question around whether the dummy model should be kept in, could be useful for other mocking/testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant