Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test conftest to not make random results #119 #162

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

priyanshubajaj
Copy link
Contributor

Changed test values from random to non-deterministic using a seed value over the conftest.py file, then some of the != asserts in tests below could be stronger = asserts

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Changed test values from random to non-deterministic using a seed value over the conftest.py file, then some of the != asserts in tests below could be stronger = asserts
@peterdudfield peterdudfield reopened this Jan 10, 2025
@peterdudfield peterdudfield merged commit e347ff2 into openclimatefix:main Jan 10, 2025
@peterdudfield
Copy link
Contributor

Thanks @priyanshubajaj

@peterdudfield
Copy link
Contributor

@all-contributors please add @priyanshubajaj for test

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @priyanshubajaj! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants