Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old stuff #146

Closed
4 tasks done
matteofigus opened this issue Nov 17, 2015 · 6 comments
Closed
4 tasks done

Remove old stuff #146

matteofigus opened this issue Nov 17, 2015 · 6 comments

Comments

@matteofigus
Copy link
Member

Looks like some stuff was a good idea at the beginning, not sure we really need some stuff anymore:

  • oc link (as consumer, you do oc link header@1.2.3 to add it to local oc.json file)
  • oc unlink (as consumer, you remove the linked component from oc.json file)
  • oc info (to see info about a linked component and in case suggest upgrade)
  • oc ls (to see all components for linked registry - we have the web interface now for that)

So, democratically, I am gonna ask top 4 contributors and my vote is gonna be counted only if is gonna be a tie. Please vote for each one until Friday night replying here for keeping or killing each one of those functionalities.

@jankowiakmaria @andyroyle @federicomaffei @tpgmartin

@federicomaffei
Copy link
Collaborator

@matteofigus - Good idea to involve contributors. Personally haven't been a huge user of the cli part so far, so a bit difficult for me to make a call.
What are your concerns about those commands? Maybe the fact that they are not useful enough and/or the state of the code (e.g. not tested, not updated as the rest, not enough time to maintain them, etc.)?

@matteofigus
Copy link
Member Author

The concerns are that if something is not needed, it should be killed asap to keep code smaller and more maintainable. OC is growing and I believe that if we kill what we don't need anymore we can focus on the new stuff.

@andyroyle
Copy link
Collaborator

Sorry I'm a bit late to the party.

I say kill them all.

We can always add stuff back if necessary

@jankowiakmaria
Copy link
Collaborator

👍 (sorry for late response)

@federicomaffei
Copy link
Collaborator

Let's kill 'em all @matteofigus!

@matteofigus
Copy link
Member Author

Good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants