Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of npm-shrinkwrap #404

Closed
matteofigus opened this issue Mar 13, 2017 · 1 comment
Closed

get rid of npm-shrinkwrap #404

matteofigus opened this issue Mar 13, 2017 · 1 comment

Comments

@matteofigus
Copy link
Member

matteofigus commented Mar 13, 2017

So, I am creating an issue to track this.

why the shrinkwrap?

To be clear, the reason we have the shrinkwrap atm is to override some subdependencies on the jade module that are unsecure (old versions of uglify-js). This is bad because every module change needs a rework on the npm-shrinkwrap, and to limit bad scenarios and quick PR reviews we need to make surgical changes to that file in that regard.

future plan

get rid of it when #298 will be complete.

in the meanwhile

when working on a dependency,

  • use npm 2 by sudo npm i npm@2
  • run npm install <module> --save
  • diff the npm-shrinkwrap file and rework it manually in order to avoid any changes to other modules, only the ones about the module added or upgraded
  • check in the change in the PR
@matteofigus
Copy link
Member Author

Update: I found this awesome module: https://github.com/jnordberg/jade-legacy which is jade + security patches, all green on snyk: https://snyk.io/test/github/jnordberg/jade-legacy

Perhaps by switching jade=>jade-legacy we can safely remove the shrinkwrap as the security patches wouldn't be problematic anymore. /cc @nickbalestra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants