Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPT-537]Cli init allows for --templateType to be npm module #433

Closed
wants to merge 9 commits into from

Conversation

nickbalestra
Copy link
Contributor

@nickbalestra nickbalestra commented Apr 3, 2017

If the templatetype passed to the init comand is not 'jade' or 'handlebars' (default) but a valid oc-template module, the cli will download it and use it to generate boilerplate.

Example of boilerplate code used by the cli to generate a component

  • Coded to easily add yarn in the future 😍 (not yet supported)
  • Don't install template if already available on local dev registry
  • Use boilerplate code hosted template
  • add readme into boilerplates
  • logger dependcy injection
  • unit tests

@nickbalestra nickbalestra changed the title [GPT-537]Cli init allows for oc-templates to be npm [GPT-537]Cli init allows for oc-templates to be npm modules Apr 3, 2017
@nickbalestra nickbalestra changed the title [GPT-537]Cli init allows for oc-templates to be npm modules [GPT-537]Cli init allows for --templateType to be npm module Apr 3, 2017
@nickbalestra nickbalestra force-pushed the GPT-537 branch 2 times, most recently from 78ceb62 to dfb18f1 Compare April 3, 2017 22:40
@nickbalestra nickbalestra changed the title [GPT-537]Cli init allows for --templateType to be npm module [WIP][GPT-537]Cli init allows for --templateType to be npm module Apr 4, 2017
@nickbalestra
Copy link
Contributor Author

Need to add some tests, but the CLI now allows to init from local modules or npm modules :)
🎉

oc-dev

@nickbalestra nickbalestra changed the title [WIP][GPT-537]Cli init allows for --templateType to be npm module [GPT-537]Cli init allows for --templateType to be npm module Apr 5, 2017
@nickbalestra nickbalestra changed the title [GPT-537]Cli init allows for --templateType to be npm module [WIP][GPT-537]Cli init allows for --templateType to be npm module Apr 5, 2017
@nickbalestra nickbalestra changed the title [WIP][GPT-537]Cli init allows for --templateType to be npm module [GPT-537]Cli init allows for --templateType to be npm module Apr 13, 2017
@nickbalestra nickbalestra changed the title [GPT-537]Cli init allows for --templateType to be npm module [WIP][GPT-537]Cli init allows for --templateType to be npm module Apr 24, 2017
@nickbalestra nickbalestra changed the title [WIP][GPT-537]Cli init allows for --templateType to be npm module [GPT-537]Cli init allows for --templateType to be npm module May 9, 2017
@nickbalestra nickbalestra added wip and removed wip labels May 9, 2017
@nickbalestra nickbalestra force-pushed the GPT-537 branch 2 times, most recently from c758d32 to 8a3e382 Compare May 10, 2017 12:44
@nickbalestra
Copy link
Contributor Author

Created a templates branch where all the work in relation to templates is going to be pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants