-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace jshint by eslint #450
Conversation
I've read your mind before so opened #449 💃 |
haha did not see it :p Then I'll merge my branch with master when your PR is accepted. I remove that question from the PR, but please, try to answer the other ones too 😃 |
Added note:
|
I've removed the Tests run perfect locally, but for some reason weren't executed in travis nor in appveyor. |
PS. Merging with master, as #449 has been merged |
Added:
|
Merged with master and fixed Note that I've set |
This looks good to me for now. Let's create separate issues for each rule that we may want to change. Agree about the no-strict, in case let's make a different PR for that. Thanks for working on this! |
I'm creating the PR as a WIP because I'm currently working on it and I see things which create some questions for me:
no-undef
errors due to the injected libraries (under testing, theit
anddescribe
, more specifically). I've currently switch the rule to show warnings instead of errors, but I think it's better to disable it adding/* eslint no-undef: 'off' */
for each test file that brings an error. If you're ok with it, I'll do a commit re-enabling the rule and setting the rule file by file.no-console
towarn
. Would you like to set it to off, or is it ok to stay as warnings?I'll also try to edit this post to add some notes about some decisions I made:
eslint --init
. There are a lot of rules set tooff
that you may want to check.no-extra-boolean-cast
towarn
in order to change from errors to warnings, so you don't forget about it :pno-empty
with"allowEmptyCatch": true
, to allow emptycatch
statements..eslintignore
file as agrunt-eslint
parameter, I've decided to move both.eslintrc.json
and.eslintignore
to the root path, and remove thetasks/support
folder, which was containing the.jshintrc
file.strict
rules, as they're not needed for nodejs modules (they're in strict mode by default).refs #436