From 46132da41601cbbe7b4f031bc18a3e507291e38c Mon Sep 17 00:00:00 2001 From: Charles Chu Date: Sat, 1 Aug 2015 19:43:13 -0700 Subject: [PATCH] Support minify ie8 compatible css option --- cli/domain/local.js | 9 +++++---- docs/getting-started.md | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cli/domain/local.js b/cli/domain/local.js index 9329cd380..0c906374c 100644 --- a/cli/domain/local.js +++ b/cli/domain/local.js @@ -102,7 +102,7 @@ module.exports = function(){ }; var missingDependencies = function(requires, component){ - return _.filter(requires, function(dep){ + return _.filter(requires, function(dep){ return !_.contains(_.keys(component.dependencies), dep); }); }; @@ -229,7 +229,7 @@ module.exports = function(){ localConfig.components[componentName] = componentVersion; fs.writeJson(settings.configFile.src, localConfig, callback); - }); + }); }); }, mock: function(params, callback){ @@ -379,8 +379,9 @@ module.exports = function(){ fs.writeFileSync(fileDestination, minifiedContent); } else if(minify && fileExt === '.css' && component.oc.minify !== false){ - fileContent = fs.readFileSync(filePath).toString(), - minifiedContent = new CleanCss().minify(fileContent).styles; + fileContent = fs.readFileSync(filePath).toString(); + var options = (component.oc.ie8css === true) ? {compatibility:'ie8'} : null; + minifiedContent = new CleanCss(options).minify(fileContent).styles; fs.writeFileSync(fileDestination, minifiedContent); } else { diff --git a/docs/getting-started.md b/docs/getting-started.md index e0da99d00..e1091cbee 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -85,6 +85,7 @@ The basic package file `package.json` looks as follows: |`oc.files.template.type`|`string`|the template engine's type, by default `handlebars`| |`oc.files.static`|`array of strings`|An array of directories that contain static resources referenced from the component's markup| |`oc.minify`|`boolean`|Default `true`, will minify static css and js files during publishing| +|`oc.ie8css`|`boolean`|Default `false`, if true, will minify ie8 compatible css files during publishing| |`oc.plugins`|`array of strings`|the [plugins](registry.md#plugins) the component requires| ## Template