Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to use SAI-Challenger as a 3rd party lib #20

Open
anton7811 opened this issue Nov 19, 2022 · 3 comments
Open

It should be possible to use SAI-Challenger as a 3rd party lib #20

anton7811 opened this issue Nov 19, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@anton7811
Copy link
Collaborator

It should be possible to easily build a custom SAI-Challenger docker with additional software inside and custom test cases.

Currently, there are 2 main issues with this:

  1. tests folder and working directory MUST be directly in /sai-challenger folder and only on the first level otherwise sai_npu load fails
  2. SAI-Challenger packages are installed directly to the search path and make some mess there. I would expect to have them in the same location as it is done for PTF. When all modules are installed into ptf (specifically /usr/local/lib/python3.7/dist-packages/ptf) folder and any import can be done like from ptf import something.

Possible use case:
a. Custom SAI-Challenger client container for testing HW using customized tests and test tools
b. Using SAI-Challenger as a 3rd party module in other projects where folder structure may be different.

@andriy-kokhan
Copy link
Contributor

Thank you for you input.
Just not sure I understood the first statement - "tests folder and working directory MUST be directly in /sai-challenger". Could you please provided an example of the expected usage?

@anton7811
Copy link
Collaborator Author

@andriy-kokhan, answering your question:
When I'm launching tests the working directory should be "/sai-challenger/". And If I have my own folder structure, e.g.: "/my/tests" or even "/sai-challenger/custom/tests" it won't work. So the user is obligated to have a specific folder structure. Putting custom user tests into the SAI-Challenger root may cause additional and unnecessary steps.

@andriy-kokhan
Copy link
Contributor

This issue is expected to be addressed in scope of #26. Specifically, by 31fd92a

@andriy-kokhan andriy-kokhan self-assigned this Dec 27, 2022
@andriy-kokhan andriy-kokhan added the enhancement New feature or request label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants