From 06a86bd6a08f5c1d3e456d668aee9bfb027098aa Mon Sep 17 00:00:00 2001 From: Ze Gan Date: Wed, 30 Oct 2024 10:27:44 +0800 Subject: [PATCH] Fix comments Signed-off-by: Ze Gan --- doc/TAM/SAI-Proposal-TAM-stream-telemetry.md | 9 +++++---- inc/saiswitch.h | 1 + inc/saitypes.h | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/doc/TAM/SAI-Proposal-TAM-stream-telemetry.md b/doc/TAM/SAI-Proposal-TAM-stream-telemetry.md index 7205a9860..4c62ab4e2 100644 --- a/doc/TAM/SAI-Proposal-TAM-stream-telemetry.md +++ b/doc/TAM/SAI-Proposal-TAM-stream-telemetry.md @@ -276,7 +276,7 @@ struct genl_multicast_group stel_mcgrps[] = { }; // Family definition -static struct genl_family nl_bench_family = { +static struct genl_family stel_family = { .name = "sonic_stel", .version = 1, // ... @@ -299,7 +299,7 @@ void send_msgs_to_user(/* ... */) nla_append(skb_out, msg->data, msg->len); } - genlmsg_multicast(&genl_family, skb_out, 0, 0/* group_id to ipfix group */, GFP_KERNEL); + genlmsg_multicast(&stel_family, skb_out, 0, 0/* group_id to ipfix group */, GFP_KERNEL); } ``` @@ -443,6 +443,7 @@ typedef enum _sai_switch_attr_t * * If the collector isn't ready to receive the report, this value indicates how many * reports that can be cached. 0 means no cache which is the default behavior. + * If the cache is full, new incoming data will be dropped. * * @type sai_uint32_t * @flags CREATE_ONLY @@ -580,7 +581,7 @@ sai_attr_list[3].id = SAI_TAM_REPORT_ATTR_TEMPLATE_REPORT_INTERVAL; sai_attr_list[3].value.s32 = 0; // Don't push the template, Because we hope the template can be proactively queried by orchagent sai_attr_list[4].id = SAI_TAM_REPORT_ATTR_REPORT_INTERVAL_UNIT; -sai_attr_list[4].value.s32 = SAI_TAM_REPORT_INTERVAL_UNIT_MSEC; +sai_attr_list[4].value.s32 = SAI_TAM_REPORT_INTERVAL_UNIT_USEC; attr_count = 5; sai_create_tam_report_fn(&sai_tam_report_obj, switch_id, attr_count, sai_attr_list); @@ -892,7 +893,7 @@ typedef struct _sai_stat_st_capability_t * * If polling interval is less than this value, it will be unacceptable. */ - uint32_t minimal_polling_interval; + uint64_t minimal_polling_interval; } sai_stat_st_capability_t; diff --git a/inc/saiswitch.h b/inc/saiswitch.h index 00c190855..0746bbf6c 100644 --- a/inc/saiswitch.h +++ b/inc/saiswitch.h @@ -3075,6 +3075,7 @@ typedef enum _sai_switch_attr_t * * If the collector isn't ready to receive the report, this value indicates how many * reports that can be cached. 0 means no cache which is the default behavior. + * If the cache is full, new incoming data will be dropped. * * @type sai_uint32_t * @flags CREATE_ONLY diff --git a/inc/saitypes.h b/inc/saitypes.h index 2e727d411..c030e6a70 100644 --- a/inc/saitypes.h +++ b/inc/saitypes.h @@ -1814,7 +1814,7 @@ typedef struct _sai_stat_st_capability_t * * If polling interval is less than this value, it will be unacceptable. */ - uint32_t minimal_polling_interval; + uint64_t minimal_polling_interval; } sai_stat_st_capability_t;