Switch scoped tunnel attributes #1173
Conversation
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
| * @objects SAI_OBJECT_TYPE_SWITCH_TUNNEL | ||
| * @default empty | ||
| */ | ||
| SAI_SWITCH_ATTR_TUNNEL_OBJECTS_LIST, |
There was a problem hiding this comment.
Can we have this as read only and have switch object ID as attribute in the sai_switch_tunnel_object? This will make it inline with other objects
There was a problem hiding this comment.
Apparently switch object can not be used as an attribute.
ASSERT FAILED (on line 779): SAI_SWITCH_TUNNEL_ATTR_SWITCH_OBJECT: switch object type can't be used as object type in any attribute
switch_id is passed as a parameter in the create API we can use it as binding but thats implicit assumption.
There was a problem hiding this comment.
yes, switch_id is passed when create object function is called, so you already have it.
i don't see a point to have object_type_switch on any attribute, and even if you want to get switch id from tunnel object id, then use sai_switch_id_query()
what was your use case ?
There was a problem hiding this comment.
@kcudnik Sudharsan was thinking if we can create a binding of switch object in SAI_OBJECT_TYPE_SWITCH_TUNNEL. I think thats implicit.
@dgsudharsan Sudharsan, what do you think?
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
Done |
| /** | ||
| * @brief Defines tunnel encap ECN mode | ||
| */ | ||
| typedef enum _sai_tunnel_encap_ecn_mode_t |
There was a problem hiding this comment.
why to move those enums to saiswitch.h instead of #include "saiswitch.h" here?
|
@itaibaz Please approve this PR. I have another set of changes on top this coming. |
|
@itaibaz - reminder if there's anything needed from your end on this PR, or you'd sign off? Thanks. |
There are 2 open comments from Marian, that needs to be addressed before we can sign off |
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
|
@rlhui Please merge this PR |
This PR is the closure of discussion in
#1153
There is switch level tunnel object which can be set for various attributes per tunnel type.