Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port FEC histogram counter support. #1617

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

mikeberesford
Copy link
Contributor

Signed-off-by: Mike Beresford mberes@google.com

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 6, 2022

please fix errors

WARNING: star should be next to param name saiswitch.h:2783:     * SAI_PORT_STAT_IF_IN_FEC_CODEWORD_ERRORS_HISTOGRAM_S* attributes.
Running Aspell
Words to check: 3002
WARNING: Word 'codeword' is misspelled saiport.h 2761:     * @brief Port FEC codeword symbol error counters.
WARNING: Word 'codewords' is misspelled saiport.h 2774:    /** Count of FEC codewords with 1 symbol error. */
WARNING: Word 'retreived' is misspelled saiport.h 2769:     * of errors that can be detected may be retreived via the

@mikeberesford mikeberesford force-pushed the fec_stats_bins branch 3 times, most recently from 6556131 to b0f42cc Compare October 6, 2022 14:57
@mikeberesford
Copy link
Contributor Author

Meta checker errors fixed

inc/saiswitch.h Outdated Show resolved Hide resolved
@mikeberesford mikeberesford force-pushed the fec_stats_bins branch 2 times, most recently from 8caa10b to 4c5578c Compare October 6, 2022 15:56
@rlhui
Copy link
Collaborator

rlhui commented Oct 6, 2022

@prgeor , please help review? thx.

@mikeberesford
Copy link
Contributor Author

@JaiOCP please review as well

@lguohan
Copy link
Collaborator

lguohan commented Oct 10, 2022

can we have code example how these attributes are used?

@mikeberesford
Copy link
Contributor Author

@lguohan is there anything in particular you'd like to see? The SAI_PORT_STAT_IF_IN_FEC_CODEWORD_ERRORS_HISTOGRAM_* are accessed in the same way as all the rest of the port counters. SAI_PORT_ATTR_MAX_FEC_ERRORS_DETECTABLE could be used to determine the number of counters to collect if desired.

inc/saiport.h Show resolved Hide resolved
inc/saiport.h Outdated Show resolved Hide resolved
@mikeberesford mikeberesford force-pushed the fec_stats_bins branch 3 times, most recently from 77635dd to fb4e92a Compare October 11, 2022 05:15
inc/saiport.h Outdated Show resolved Hide resolved
inc/saiport.h Outdated Show resolved Hide resolved
inc/saiport.h Show resolved Hide resolved
inc/saiport.h Outdated Show resolved Hide resolved
@rlhui
Copy link
Collaborator

rlhui commented Oct 14, 2022

@lguohan is there anything in particular you'd like to see? The SAI_PORT_STAT_IF_IN_FEC_CODEWORD_ERRORS_HISTOGRAM_* are accessed in the same way as all the rest of the port counters. SAI_PORT_ATTR_MAX_FEC_ERRORS_DETECTABLE could be used to determine the number of counters to collect if desired.

example code of how a NOS should read and interpret it.

Signed-off-by: Mike Beresford <mberes@google.com>
@mikeberesford mikeberesford deleted the fec_stats_bins branch June 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants