Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hines #6

Merged
merged 60 commits into from
Aug 14, 2023
Merged

Hines #6

merged 60 commits into from
Aug 14, 2023

Conversation

marcushines
Copy link
Contributor

No description provided.

marcushines and others added 25 commits July 15, 2023 02:06
@marcushines
fix embeded messages
38ebfe0
@gmacf
Fix gazelle rule and run bazel run //:gazelle
6becdc3
@gmacf
Create a simple fake client for Bootz
9eeb50f
@gmacf
Fix flag parsing and gRPC security
d4978bb
@gmacf
Add additional logging to client
10ef3b9
@gmacf
Add logic to validate OVs and OCs as well as a short README.
8ee8f51
@gmacf
Verify SignedResponse signature using RSA public/private keys.
624a836
@gmacf
Address some PR comments
f97634b
@gmacf
Move certificate directory and address some PR comments.
51be474
@marcushines
Merge pull request #8 from gmacf/hines
6312585 
Add a simple fake client to Bootz
@marcushines
Update README.md
94fe8f1
@gmacf
Create a script to generate PDC, OC, OVs and Vendor CA certs.
d810410
@gmacf
Address PR comments
c34a669
@gmacf
Move service.go to a buildable state
1560876
@gmacf
Move server.go to a buildable state.
9a6e553
@gmacf
Move entitymanager.go to a buildable state
ab68e68
@marcushines
Merge branch 'main' of github.com:openconfig/bootz
44f8177
@gmacf @marcushines
Fix gazelle rule and run bazel run //:gazelle
3088764
@gmacf @marcushines
Create a simple fake client for Bootz
e93b660
@gmacf @marcushines
Fix flag parsing and gRPC security
65c4616
@gmacf @marcushines
Add additional logging to client
a5977f1
@gmacf @marcushines
Add logic to validate OVs and OCs as well as a short README.
c460fad
@gmacf @marcushines
Verify SignedResponse signature using RSA public/private keys.
752000f
@gmacf @marcushines
Address some PR comments
881ad3c
@gmacf @marcushines
Move certificate directory and address some PR comments.
2c41a1a
@marcushines marcushines requested review from robshakir and a team August 10, 2023 22:04
robshakir
robshakir requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat to have something to test against here -- bunch of comments in-line, mostly Go ones, I didn't spot anything that seemed out of whack within the bootz logic.

client/client.go Outdated Show resolved Hide resolved
client/client.go Outdated Show resolved Hide resolved
client/client.go Outdated Show resolved Hide resolved
client/README.md Outdated Show resolved Hide resolved
client/client.go Show resolved Hide resolved
server/service/service.go Show resolved Hide resolved
server/service/service.go Show resolved Hide resolved
server/service/service.go Outdated Show resolved Hide resolved
testdata/README.md Outdated Show resolved Hide resolved
testdata/generate.go Outdated Show resolved Hide resolved
marcushines and others added 7 commits August 11, 2023 20:17
@marcushines
remove binary
18af5a4
@marcushines @robshakir
Update client/client.go
b601299 
Co-authored-by: Rob Shakir <robjs@google.com>
@marcushines @robshakir
Update client/client.go
56b54f9 
Co-authored-by: Rob Shakir <robjs@google.com>
@marcushines @robshakir
Apply suggestions from code review
5f18d69 
Co-authored-by: Rob Shakir <robjs@google.com>
@marcushines
address comments and regen pb.go
f042490
@marcushines
remove dup file
2aa3219
@marcushines
Update service.go
0ad4e76
@marcushines marcushines merged commit 96c5832 into main Aug 14, 2023
6 checks passed
@marcushines marcushines deleted the hines branch August 14, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robshakir robshakir robshakir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcushines @robshakir @gmacf