Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acctz timeout behavior was removed; remove it from the yang model. #175

Merged
merged 2 commits into from
Mar 15, 2024
Merged

acctz timeout behavior was removed; remove it from the yang model. #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbad929
Fix pasto in acctz yang variable description
haussli Mar 14, 2024
757e667
Remove client-counters.IdleTimeouts from the yang model; the timeout …
haussli Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acctz/acctz.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ message RecordResponse {
// since the unix epoch (Jan 1, 1970 00:00:00 UTC).
google.protobuf.Timestamp timestamp = 2;

// True, if the server’s history is missing records prior to the time
// True, if the server's history is missing records prior to the time
// specified in the timestamp of the RecordResponse message. This can happen
// in the below scenarios,
// 1. A client connects and sends RecordRequest(timestamp=t1). If the server
Expand Down
16 changes: 5 additions & 11 deletions acctz/gnsi-acctz.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,10 @@ module gnsi-acctz {
leaf history_istruncated {
type oc-yang:counter64;
description
"The total number of times that a RecordRequest resulted in
a RecordResponse being marked history_istruncated. ie: a
request was made for a timestamp that did not exist in the
history.";
}
leaf IdleTimeouts {
type oc-yang:counter64;
description
"The total number of times that a client was disconnected
due to missing keepalives (ie: RecordRequests).";
"The total number of times that a RecordResponse were marked
with history_istruncated true. ie: a request was made for a
timestamp that did not exist in the history or another
qualifying event as documented in acctz.prot.";
}
leaf RecordRequests {
type oc-yang:counter64;
Expand All @@ -130,7 +124,7 @@ module gnsi-acctz {
leaf RecordResponses {
type oc-yang:counter64;
description
"The total number of RecordRequest RPCs that have been sent.";
"The total number of RecordResponse RPCs that have been sent.";
}
}

Expand Down
Loading