Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node creation should happen concurrently #140

Open
ashutshkumr opened this issue Apr 29, 2022 · 0 comments
Open

Node creation should happen concurrently #140

ashutshkumr opened this issue Apr 29, 2022 · 0 comments

Comments

@ashutshkumr
Copy link
Contributor

Here's a rough flow of sequence of operations:

  1. Get meshnet topology spec for each node, in sequence
  2. Review each spec to ensure peer node name consists of actual pod name for a given peer node (since node != pod)
  3. Create meshnet CR for each spec, in sequence
  4. Delegate node creation to vendor specific implementation, in sequence
  5. Loop through all nodes and call vendor specific implementation to ensure the corresponding node is ready, in sequence

4. and 5. is specifically a problem because operation on a given node blocks the operation on subsequent nodes. This causes significant slowness as we increase the number of nodes in a topology.

It should be feasible to enhance them to operate concurrently (one goroutine for each node).

There's also the opportunity to make 1. and 3. concurrent but I do not have enough data to confirm that it causes significant slowness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant