Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto changes for host constraints #415

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Conversation

NehaManjunath
Copy link
Collaborator

No description provided.

Copy link
Contributor

@alexmasi alexmasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! left some comments mostly nits about the naming. After these are addressed lets have Paul take a look as well to see what he thinks about the design

proto/topo.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
proto/topo.proto Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5872310372

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.787%

Totals Coverage Status
Change from base Build 5811814366: 0.0%
Covered Lines: 3988
Relevant Lines: 6062

💛 - Coveralls

@NehaManjunath NehaManjunath merged commit 62666fe into main Aug 15, 2023
7 of 8 checks passed
@alexmasi alexmasi deleted the host-constraints-proto branch October 6, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants