Support external tags #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
damirabdul
added
scope: backend
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.../java/org/opendatadiscovery/oddplatform/repository/reactive/ReactiveLabelRepositoryImpl.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
...c/main/java/org/opendatadiscovery/oddplatform/service/ingestion/TagIngestionServiceImpl.java
Outdated
Show resolved
Hide resolved
...atform-api/src/main/java/org/opendatadiscovery/oddplatform/service/IngestionServiceImpl.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
DementevNikita
approved these changes
Jul 15, 2022
…tform into ingestion_tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
This PR introduces system tags and system labels to odd-platform.
Specification: opendatadiscovery/opendatadiscovery-specification#44
Platform can parse data entity tags, which come from collector and create relations between tags and data entities. If we already have such tag in the platform it will be just linked to the data entity, otherwise new tag will be created.
Those external relation will be shown in a different design and user will not be allowed to remove such tags from data entity.
Each set of tags represents the whole relations state, e.g. if data entity A had system tags [B, D] and then we received ingestion request where this entity A has system tags [C, D] it means, that we need to remove tag B and add tag C.
If tag has at least one external relation with data entity, it will not be allowed to edit/delete this tag from Management section.
All these statements are applied to relations between labels and dataset fields as well.
Closes #766
Is there anything you'd like reviewers to focus on?
How to test
It will be good to test all possible scenarios with different tags combination, e.g. create new data entity with system tags, add system tags to existing data entity, add system tags to existing data entity, which already has custom user tags, etc.