Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story]: Create migration for GPU users to accelerator profiles #1598

Closed
Gkrumbach07 opened this issue Jul 27, 2023 · 0 comments · Fixed by #1618
Closed

[Story]: Create migration for GPU users to accelerator profiles #1598

Gkrumbach07 opened this issue Jul 27, 2023 · 0 comments · Fixed by #1618
Assignees
Labels
feature/accelerator-support All things related to Accelerators infrastructure Anything non feature/* related that improves general working of the Dashboard kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@Gkrumbach07
Copy link
Member

Goal

Create a migration so that users using gpus are automatically migrated to accelerator profiles

Dependency issue

Itemized goals

  • Backend — When we startup — in kube.ts we can handle a migration (catch ALL promise errors — exit gracefully and use fastify logging)
    • Check for migration-gpu-status configmap in dashboard namespace — if found, exit early
    • Read existing AcceleratorProfiles
    • If > 0 — do nothing, exit early
    • If 404 shows up — CRD may not be installed, exit early
    • If not 404, but 0 returned:
      • if — create our default migrated-gpu with nvidia.com/gpu identifier, Nivida GPU display name, enabled, toleration equal to our existing setting (before Habana)
      • If bad detection, error or whatever — exit early
      • If can’t find GPUs, create the configmap anyways (next step)
    • Create configmap to flag operation as successful — migration-gpu-status in the dashboard namespace, simple stringData of migrated-completed: true
  • UI does nothing special for upgrade, reacts purely on data
    • Don’t show any dropdown if no AcceleratorProfile CRs exist
    • Don’t error out if CRD doesn’t exist
    • Show dropdown normally no matter how many of those or origin of those AcceleratorProfile CRs

Aspects continued elsewhere

No response

Mocks

No mocks

@Gkrumbach07 Gkrumbach07 added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Jul 27, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Jul 27, 2023
@Gkrumbach07 Gkrumbach07 added infrastructure Anything non feature/* related that improves general working of the Dashboard feature/accelerator-support All things related to Accelerators labels Jul 27, 2023
@Gkrumbach07 Gkrumbach07 added this to the Accelerator Support milestone Jul 27, 2023
@Gkrumbach07 Gkrumbach07 self-assigned this Jul 27, 2023
@Gkrumbach07 Gkrumbach07 moved this from Needs prioritization to In progress in ODH Dashboard Planning Jul 27, 2023
This was referenced Jul 27, 2023
@Gkrumbach07 Gkrumbach07 linked a pull request Jul 31, 2023 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ODH Dashboard Planning Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accelerator-support All things related to Accelerators infrastructure Anything non feature/* related that improves general working of the Dashboard kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant