Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gpu migration #1618

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Jul 31, 2023

relies on #1628

closes: #1598

Description

Adds GPU migration to accelerator profiles

How Has This Been Tested?

  1. set up cluster using GPUs
  2. start dashboard server and have the migration code run
  3. A new AcceleratorProfile resource should be created and a ConfigMap created for a successful migration
  4. open cluster without GPUs
  5. migration should fail as it is missing AcceleratorProfile CRD - no ConfigMap
  6. add AcceleratorProfile CRD
  7. migration should create config map but not a accelerator profile resource

Test Impact

is backend, no testing there yet

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 31, 2023
@openshift-ci openshift-ci bot requested review from alexcreasy and lucferbux July 31, 2023 14:54
@Gkrumbach07 Gkrumbach07 linked an issue Jul 31, 2023 that may be closed by this pull request
@Gkrumbach07 Gkrumbach07 changed the title [WIP] added gpu migration added gpu migration Aug 1, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 1, 2023
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1a1da24 into opendatahub-io:accelerator-support Aug 8, 2023
@Gkrumbach07 Gkrumbach07 deleted the migration branch August 10, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Create migration for GPU users to accelerator profiles
3 participants