Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rbac accelerator role #1754

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Sep 5, 2023

Description

Add rbac roles for authenticated user to allow them to fetch, get, and watch all accelerator profiles

How Has This Been Tested?

oc apply the yaml and impersonate a regular non cluster admin user. If you have acceleratorprofiles, then you should be able to see the dropdown when creating a workbench

Test Impact

n/a - no tests for manifest

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andrewballantyne
Copy link
Member

/hold

There seems to be reports this doesn't fully work on the ODH Nightly cluster -- more investigation is needed.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Sep 6, 2023
@andrewballantyne
Copy link
Member

/unhold
/approve

Turns out the UI was using an old "fetch every accelerator profile across the cluster" request signature, which this role would not solve. So we implemented a ClusterRole + ClusterRoleBinding hack for the cluster while we wait for the UI to be updated on it.

This effort does what was expected, approving.

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Sep 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1fe5489 into opendatahub-io:f/accelerator-support Sep 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants