This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
remove clock Guice binding #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
============================================
- Coverage 72.04% 72.02% -0.03%
Complexity 1968 1968
============================================
Files 199 199
Lines 9463 9465 +2
Branches 844 844
============================================
- Hits 6818 6817 -1
- Misses 2233 2236 +3
Partials 412 412
Flags with carried forward coverage won't be shown. Click here to find out more.
|
weicongs-amazon
approved these changes
Nov 3, 2020
| @@ -525,14 +522,6 @@ protected Clock getClock() { | |||
| return Clock.systemUTC(); | |||
| } | |||
There was a problem hiding this comment.
remove getClock() this method if it is not used anymore?
There was a problem hiding this comment.
It's still being used.
yizheliu-amazon
approved these changes
Nov 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #299 *
Description of changes:
Conflict Guice binding for Clock.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.